Re: Admin css question for 1.10.7

On 8/05/2017 11:02 PM, Melvyn Sopacua wrote:
>
> On Monday 08 May 2017 03:57:01 Tim Graham wrote:
>
> > You need to clone the Django repository and run the bisect command
>
> > from there:
>
> Simplicity in Unix:
>
> 1 #!/bin/sh
>
> 2
>
> 3 # Basically, make grep -qv behave like I want it to
>
> 4
>
> 5 file='django/contrib/admin/static/admin/css/forms.css'
>
> 6 bad='form .wide p, form .wide input + p.help {'
>
> 7
>
> 8 fgrep -q "$bad" $file
>
> 9 if [ $? -eq 0 ]
>
> 10 then
>
> 11 exit 1
>
> 12 else
>
> 13 exit 0
>
> 14 fi
>
> Results:
>
> % git bisect start 2c3c029ede 0b9f366c60
>
> Bisecting: a merge base must be tested
>
> [39d95fb6ada99c59d47fa0eae6d3128abafe2d58] Fixed #24092 -- Widened
> base field support for ArrayField.
>
> % git bisect run `pwd`/invert.sh
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 1196 revisions left to test after this (roughly 10 steps)
>
> [3d650e80ad47fdf3e7758766d2b00ed3c1efb089] Added today's security
> issues to the archive.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 598 revisions left to test after this (roughly 9 steps)
>
> [672de44e242369d29136bbf1f3ae1059dd787936] [1.9.x] Replaced "inbuilt"
> with more common "built-in".
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 298 revisions left to test after this (roughly 8 steps)
>
> [e8bfc1c74767ba902846ed0736327ce400112f3c] Stopped returning mirrors
> from setup_databases.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 149 revisions left to test after this (roughly 7 steps)
>
> [566a01e916a0565db5af8dfb5ac9ce2fafc74c66] [1.9.x] Removed unused
> views.debug.linebreak_iter() function.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 74 revisions left to test after this (roughly 6 steps)
>
> [b0c56b895fd2694d7f5d4595bdbbc41916607f45] Fixed #24496 -- Added CSRF
> Referer checking against CSRF_COOKIE_DOMAIN.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 36 revisions left to test after this (roughly 5 steps)
>
> [b1a29541e5d37c03becde6c84e793766ef23395c] Merge pull request #4761
> from aaugustin/parallelize-tests-attempt-1
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 18 revisions left to test after this (roughly 4 steps)
>
> [eaa3c883450f3c7ea939992ed075257bbac3d8b2] Refs #22258 -- Fixed an
> unclosed temporary file in fixtures test.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 8 revisions left to test after this (roughly 3 steps)
>
> [29d52583e77b247aceeb2f514177a8a6c21ed786] Removed 'Test that' prefix
> from admindocs tests.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 4 revisions left to test after this (roughly 2 steps)
>
> [b929d2d09d24705bc59d1d172921e1feade2777b] Fixed #25200 -- Updated
> tutorial screenshots for new admin theme.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 1 revision left to test after this (roughly 1 step)
>
> [19f98946f2b31b62303aedb5b30951ca295116d8] Fixed #25358 -- Improved
> variable name for question in tutorial.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
>

Now I get it!

> [e23e7b2ffe8e282adfd5c597df25c181413c5b3b] Fixed #11544 -- Removed
> !important rules in contrib.admin styles.
>
> running /home/melvyn/hg/django-project/invert.sh
>
> e23e7b2ffe8e282adfd5c597df25c181413c5b3b is the first bad commit
>
> commit e23e7b2ffe8e282adfd5c597df25c181413c5b3b
>
> Author: elky <mansellfan@gmail.com>
>
> Date: Mon Sep 7 00:28:14 2015 +0500
>
> Fixed #11544 -- Removed !important rules in contrib.admin styles.
>

Should I now contact elky and start a conversation?

Thanks Tim and Melvyn

Mike

> :040000 040000 8ba07a707a8493e0eed28fd23cb0e0d1b29e4e69
> 756ac7c45cced7bb403573eb4d31a70c250fddf8 M django
>
> bisect run success
>
> Happy hunting.
>
> --
>
> Melvyn Sopacua
>
> --
> You received this message because you are subscribed to the Google
> Groups "Django users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to django-users+unsubscribe@googlegroups.com
> <mailto:django-users+unsubscribe@googlegroups.com>.
> To post to this group, send email to django-users@googlegroups.com
> <mailto:django-users@googlegroups.com>.
> Visit this group at https://groups.google.com/group/django-users.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/django-users/3834087.V7UGXNyRTa%40devstation
> <https://groups.google.com/d/msgid/django-users/3834087.V7UGXNyRTa%40devstation?utm_medium=email&utm_source=footer>.
> For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-users+unsubscribe@googlegroups.com.
To post to this group, send email to django-users@googlegroups.com.
Visit this group at https://groups.google.com/group/django-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-users/ebdb2b8b-c667-c3e8-aca8-f97b338bcdef%40dewhirst.com.au.
For more options, visit https://groups.google.com/d/optout.