Sunday, October 23, 2022

Sanity check please

In the Django Admin I have a model central to a bunch of FKs and M:Ms plus a lot of processing on saving.

This is my solution which seems to work but frightens me a bit.

class Chemical(models.Model):
      # lots of fields
      def save(self, *args, **kwargs):
        self.process_stuff_based_on_field_values_pre_save()
        first = False
        if not self.id:
            first = True
            super().save(force_insert=True, *args, **kwargs)
        if self.id:
            self.create_or_update_a_bunch_of_related_records(first=first)
        super().save(force_insert=False, *args, **kwargs)
        self.create_or_update_a_bunch_of_m2m_records(first=first)
      def process_stuff_based_on_field_values_pre_save(self, first=False):          ...            def create_or_update_a_bunch_of_m2m_records(self, first=False):          ...          # lots of other methods
  
Thanks for any warnings, caveats

Cheers

Mike

--   Signed email is an absolute defence against phishing. This email has  been signed with my private key. If you import my public key you can  automatically decrypt my signature and be sure it came from me. Just  ask and I'll send it to you. Your email software can handle signing.  

No comments:

Post a Comment